Issue 2129015: Refactored full-screen code under FullscreenWindowMac base class and...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2129015: Refactored full-screen code under FullscreenWindowMac base class and... (Closed)

Created:
10 years, 7 months ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
maf

CC:
o3d-review_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Refactored full-screen code under FullscreenWindowMac base class and overlay window code into OverlayWindowMac class. This is an intermediate step toward a Cocoa and CGL implementation. Verified that mouse and key events continue to work in full-screen mode with full-screen sample and a modified render-mode.html in Firefox 3.6.3 on Mac OS X, where O3D continues to use the Quickdraw drawing model. BUG=http://code.google.com/p/o3d/issues/detail?id=221 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47733

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+861 lines, -569 lines)			Patch
M	plugin/cross/o3d_glue.h	View		5 chunks	+20 lines, -25 lines	0 comments	Download
M	plugin/cross/o3d_glue.cc	View		2 chunks	+0 lines, -8 lines	0 comments	Download
A	plugin/mac/fullscreen_window_mac.h	View	1	1 chunk	+82 lines, -0 lines	0 comments	Download
A	plugin/mac/fullscreen_window_mac.mm	View		1 chunk	+388 lines, -0 lines	0 comments	Download
M	plugin/mac/main_mac.mm	View		7 chunks	+8 lines, -7 lines	0 comments	Download
A	plugin/mac/overlay_window_mac.h	View	1	1 chunk	+62 lines, -0 lines	0 comments	Download
A	plugin/mac/overlay_window_mac.mm	View		1 chunk	+286 lines, -0 lines	0 comments	Download
M	plugin/mac/plugin_mac.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	plugin/mac/plugin_mac.mm	View		7 chunks	+8 lines, -529 lines	0 comments	Download
M	plugin/plugin.gyp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages