Issue 2128003: Changed two files end-line to make it work better with GYP. They were DOS (CR...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2128003: Changed two files end-line to make it work better with GYP. They were DOS (CR... (Closed)

Created:
10 years, 7 months ago by hansl_g

Modified:
9 years, 7 months ago

Reviewers:
Sigurður Ásgeirsson

CC:
chromium-reviews

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Changed two files end-line to make it work better with GYP. They were DOS (CR/LF), now they are UNIX (CR). It seems like the base gyp scripts on Windows were confused about this and didn't handle it well, while using gyp through gclient worked perfectly. I did not investigate the causes further. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=599

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -111 lines)			Patch
	M	src/client/windows/unittests/client_tests.gyp	View		1 chunk	+54 lines, -54 lines	0 comments	Download
	M	src/client/windows/unittests/gtest.gyp	View		1 chunk	+57 lines, -57 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

hansl_g

I think I found Emmanuel's problem. Check out if it makes sense please. Thanks.

10 years, 7 months ago (2010-05-14 18:13:29 UTC) #1

Sigurður Ásgeirsson

10 years, 7 months ago (2010-05-14 18:23:25 UTC) #2

lgtm, you might want to consider 'svn pset svn:eol-style
lf
' Þ

Expand Messages | Collapse Messages