fix for issue 2610

fix for issue 2610
  - add --recovery flag to chromeos-installer script to install a recovery
    image from partition B onto a device's hard drive
  - add temporary workaround to populate partition B to make installer work
  - TODO(tgao): write a script to populate partition B and remove workaround

[adlr, 2010-05-20 18:21:33]

http://codereview.chromium.org/2127010/diff/1/2
File src/platform/installer/chromeos-install (right):

http://codereview.chromium.org/2127010/diff/1/2#newcode229
src/platform/installer/chromeos-install:229: $ESP_IMG false $FLAGS_recovery
hm, in this case i thought you wanted to keep the hard drive's GPT partition
layout the same. why do you need to change what's on the hard drive?

http://codereview.chromium.org/2127010/diff/1/3
File src/scripts/build_gpt.sh (right):

http://codereview.chromium.org/2127010/diff/1/3#newcode152
src/scripts/build_gpt.sh:152: # TODO(tgao): write a script to populate ROOT-B
and KERN-B with user-specified
i'm not sure what this is for. is it installing something into the recovery USB
image?

[Tan Gao, 2010-05-20 19:55:31]

http://codereview.chromium.org/2127010/diff/1/2
File src/platform/installer/chromeos-install (right):

http://codereview.chromium.org/2127010/diff/1/2#newcode229
src/platform/installer/chromeos-install:229: $ESP_IMG false $FLAGS_recovery
good catch. reverted

http://codereview.chromium.org/2127010/diff/1/3
File src/scripts/build_gpt.sh (right):

http://codereview.chromium.org/2127010/diff/1/3#newcode152
src/scripts/build_gpt.sh:152: # TODO(tgao): write a script to populate ROOT-B
and KERN-B with user-specified
yes. per our discussion before. the USB image should boot into partition A but
install content of partition B onto the device's rootfs and kernel. Currently,
without this block, partition B would not be bootable. eventually, it was my
understanding that another script is needed so that a user can load custom OS
into partition B and use the USB stick to recover their device. with this block,
user basically installs partition A onto the hard drive (since partition B is
currently identical to partition A). in the future, maybe a user can choose to
install a newer version of Chrome OS into partition B without touching content
of partition A

[adlr, 2010-05-20 20:41:22]

LGTM w/ small nit

http://codereview.chromium.org/2127010/diff/11001/12002
File src/scripts/build_gpt.sh (right):

http://codereview.chromium.org/2127010/diff/11001/12002#newcode157
src/scripts/build_gpt.sh:157: $sudo dd if=${KERNEL_IMG} of=${OUTDEV}
conv=notrunc bs=512 seek=${START_KERN_B}
wrap this and the next line to 80 cols (you'll need a \ )

[Tan Gao, 2010-05-20 20:50:40]

http://codereview.chromium.org/2127010/diff/11001/12002
File src/scripts/build_gpt.sh (right):

http://codereview.chromium.org/2127010/diff/11001/12002#newcode157
src/scripts/build_gpt.sh:157: $sudo dd if=${KERNEL_IMG} of=${OUTDEV}
conv=notrunc bs=512 seek=${START_KERN_B}
good style! fixed START_KERN_A line above as well :-)