Solved 2 bugs which caused Chrome to maximize itself when...

chrome/views/view.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/views/view.h"
 
 #include <algorithm>
 
 #ifndef NDEBUG
 #include <iostream>
@@ skipping 435 matching lines @@
 
 /////////////////////////////////////////////////////////////////////////////
 //
 // View - tree
 //
 /////////////////////////////////////////////////////////////////////////////
 
 bool View::ProcessMousePressed(const MouseEvent& e, DragInfo* drag_info) {
   const bool enabled = enabled_;
   int drag_operations;
   if (enabled && e.IsOnlyLeftMouseButton() && HitTest(e.location()))

[Peter Kasting, 2009/02/18 16:58:25]

Nit: Maybe this should also be changed to IsLeftMouseButton(), to match your
change elsewhere?  (and perhaps use ?: to match your change just below)

[idanan, 2009/02/18 18:02:23]

Tried to drag with both left and right buttons on Windows and that does not
work. So, to imitate windows better keep dragging on only one button down. (In
the case of having 2 boolean operations in the condition, I prefer using in if 
to maintain readability).

[Peter Kasting, 2009/02/18 18:04:30]

Did you try left + middle?

[idanan, 2009/02/18 18:12:25]

Seems like Windows has some complicated logic there because left-middle works on
my Trackman (but not left-right or middle-right) but on the Thinkpad only
left-drag works (not left-middle or left-right).

     drag_operations = GetDragOperations(e.x(), e.y());
   else
     drag_operations = 0;
-  ContextMenuController* context_menu_controller = context_menu_controller_;
+  ContextMenuController* context_menu_controller =
+      e.IsRightMouseButton()? context_menu_controller_ : 0;
 
   const bool result = OnMousePressed(e);
   // WARNING: we may have been deleted, don't use any View variables;
 
   if (!enabled)
     return result;
 
   if (drag_operations != DragDropTypes::DRAG_NONE) {
     drag_info->PossibleDrag(e.x(), e.y());
     return true;
@@ skipping 1118 matching lines @@
 }
 
 void View::DragInfo::PossibleDrag(int x, int y) {
   possible_drag = true;
   start_x = x;
   start_y = y;
 }
 
 }  // namespace