Don't populate WebDropData with file URLs when dragging files.

Don't populate WebDropData with file URLs when dragging files.

This is the Windows patch. There will be separate patches for Mac and Linux.

BUG=42685
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47870

[tony, 2010-05-20 05:24:19]

http://codereview.chromium.org/2126010/diff/1/2
File app/clipboard/clipboard_util_win.cc (right):

http://codereview.chromium.org/2126010/diff/1/2#newcode216
app/clipboard/clipboard_util_win.cc:216: if (!include_files) {
The early return in the middle of the function seems like it would be easy to
miss.  Maybe we should move the filename extracting into a helper function so
this function is shorter?

http://codereview.chromium.org/2126010/diff/1/2#newcode324
app/clipboard/clipboard_util_win.cc:324: return false;
Can we return the URL as plain text if it's not a file URL?

[dcheng, 2010-05-20 06:51:44]

http://codereview.chromium.org/2126010/diff/1/2
File app/clipboard/clipboard_util_win.cc (right):

http://codereview.chromium.org/2126010/diff/1/2#newcode216
app/clipboard/clipboard_util_win.cc:216: if (!include_files) {
On 2010/05/20 05:24:19, tony wrote:
> The early return in the middle of the function seems like it would be easy to
> miss.  Maybe we should move the filename extracting into a helper function so
> this function is shorter?

Done.

http://codereview.chromium.org/2126010/diff/1/2#newcode324
app/clipboard/clipboard_util_win.cc:324: return false;
On 2010/05/20 05:24:19, tony wrote:
> Can we return the URL as plain text if it's not a file URL?

Done.

[tony, 2010-05-20 07:55:20]

http://codereview.chromium.org/2126010/diff/6001/7001
File app/clipboard/clipboard_util_win.cc (right):

http://codereview.chromium.org/2126010/diff/6001/7001#newcode334
app/clipboard/clipboard_util_win.cc:334: return GetUrl(data_object, plain_text,
&title, false);
Do we need to check the actual URL?  For example, what happens if you drag a
.URL file pointing to a file:/// url (and OSExchangeData automagically turns it
into a url in the clipboard).

[dcheng, 2010-05-20 13:33:11]

http://codereview.chromium.org/2126010/diff/6001/7001
File app/clipboard/clipboard_util_win.cc (right):

http://codereview.chromium.org/2126010/diff/6001/7001#newcode334
app/clipboard/clipboard_util_win.cc:334: return GetUrl(data_object, plain_text,
&title, false);
On 2010/05/20 07:55:22, tony wrote:
> Do we need to check the actual URL?  For example, what happens if you drag a
> .URL file pointing to a file:/// url (and OSExchangeData automagically turns
it
> into a url in the clipboard).

I thought about it and decided to leave it out of this patch. The main idea
behind this change was to remove the conversion of filenames in a drag to file
URLs.

[tony, 2010-05-21 00:30:36]

On 2010/05/20 13:33:11, dcheng wrote:
> I thought about it and decided to leave it out of this patch. The main idea
> behind this change was to remove the conversion of filenames in a drag to file
> URLs.

Ok, that's fine.  LGTM.  Maybe add a TODO(dcheng) if you plan on adding it.