64-bit support for Mac OS X in base_unittests

64-bit support for Mac OS X in base_unittests.

BUG=44127, 18323
TEST=64-bit base_unittests should all pass

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47275

[Mark Mentovai, 2010-05-13 22:50:19]

We knew the day of reckoning would come for these tests. That day is May 13,
2010.

(reckoning, not something else.)

[Avi (use Gerrit), 2010-05-13 23:07:07]

http://codereview.chromium.org/2126001/diff/1/2
File base/process_util_unittest.cc (right):

http://codereview.chromium.org/2126001/diff/1/2#newcode635
base/process_util_unittest.cc:635: // allocating 2^31 bytes at a time, and with
a roomy 64-bit address space,
CFIndex is a signed long, and CFAllocatorAllocate on 64 can allocate 2^63. Are
we just worried that if we pass the first time we'll thrash the machine dead?

[Mark Mentovai, 2010-05-13 23:49:23]

New version up. Let’s test proper CFAllocator death and leave Objective-C object
allocation out. Complete comments included as to why we expect these tests to
pass in both environments, and why we can’t run the Objective-C test in the
64-bit environment.

[Avi (use Gerrit), 2010-05-13 23:57:28]

LG with comment fix.

http://codereview.chromium.org/2126001/diff/5001/2003
File base/process_util_unittest_mac.h (right):

http://codereview.chromium.org/2126001/diff/5001/2003#newcode22
base/process_util_unittest_mac.h:22: // See process_util_unittest_mac.mm for an
explanation of why function isn't
You sound Russian. "why this function" perhaps?

[Mark Mentovai, 2010-05-14 00:00:37]

Comment fixed.