src/arm/macro-assembler-arm.cc - Issue 2124022: Update and improve support for ARMv7 bitfield instructions....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/macro-assembler-arm.cc

Issue 2124022: Update and improve support for ARMv7 bitfield instructions.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/macro-assembler-arm.cc

===================================================================

--- src/arm/macro-assembler-arm.cc (revision 4740)

+++ src/arm/macro-assembler-arm.cc (working copy)

@@ -1328,7 +1328,7 @@

int num_least_bits) {

if (CpuFeatures::IsSupported(ARMv7)) {

- ubfx(dst, src, Operand(kSmiTagSize), Operand(num_least_bits - 1));

+ ubfx(dst, src, kSmiTagSize, num_least_bits);

} else {

mov(dst, Operand(src, ASR, kSmiTagSize));

and_(dst, dst, Operand((1 << num_least_bits) - 1));

« no previous file with comments | « src/arm/disasm-arm.cc ('k') | src/arm/simulator-arm.cc » ('j') | no next file with comments »