Chromium Code Reviews

Issue 2124021: Comment the code for loading and calling with interceptor. (Closed)

Created:
10 years, 7 months ago by antonm
Modified:
9 years, 4 months ago
Reviewers:
Søren Thygesen Gjesse
CC:
v8-dev
Visibility:
Public.

Description

Comment the code for loading and calling with interceptor. Committed: http://code.google.com/p/v8/source/detail?r=4717

Patch Set 1 #

Patch Set 2 : Minor corrections #

Total comments: 2
Unified diffs Side-by-side diffs Stats (+165 lines, -69 lines)
M src/arm/stub-cache-arm.cc View 12 chunks +51 lines, -21 lines 2 comments
M src/ia32/stub-cache-ia32.cc View 11 chunks +57 lines, -24 lines 0 comments
M src/x64/stub-cache-x64.cc View 12 chunks +57 lines, -24 lines 0 comments

Messages

Total messages: 3 (0 generated)
antonm
Søren, may you have a look?
10 years, 7 months ago (2010-05-25 13:42:56 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/2124021/diff/2001/3001 File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/2124021/diff/2001/3001#newcode787 src/arm/stub-cache-arm.cc:787: // holder haven't changed and thus we can ...
10 years, 7 months ago (2010-05-25 14:07:28 UTC) #2
antonm
10 years, 7 months ago (2010-05-25 14:15:09 UTC) #3
Thanks for review, committing.

http://codereview.chromium.org/2124021/diff/2001/3001
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/2124021/diff/2001/3001#newcode787
src/arm/stub-cache-arm.cc:787: // holder haven't changed and thus we can use
cached constant function.
On 2010/05/25 14:07:29, Søren Gjesse wrote:
> I am wondering whether this check can be skipped if the interceptor holder and
> the lookup holder are the same, or is that not possible?

That's a good point and it indeed could happen.  Let me address that with a
separate CL.

Powered by Google App Engine