Issue 2124020: Remove signin and persist from gaia_authenticator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2124020: Remove signin and persist from gaia_authenticator. (Closed)

Created:
10 years, 7 months ago by chron_chromium.org

Modified:
9 years, 7 months ago

Reviewers:
skrul

CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, idana, cbentzel+watch_chromium.org, darin-cc_chromium.org, tim (not reviewing), Paweł Hajdan Jr.

Visibility:
Public.

Description

Remove signin and persist from gaia_authenticator. This fixes an issue where Chromium OS did not persist sync cookies. TEST=included unit tests BUG=http://crosbug.com/2786 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48456

Patch Set 1 #

Patch Set 2 : Upload latest #

Patch Set 3 : Remove DB table. #

Patch Set 4 : Fix unit tests #

Patch Set 5 : whitespace fixes #

Patch Set 6 : final upload #

Created: 10 years, 7 months ago

	Unified diffs	Side-by-side diffs	Stats (+145 lines, -213 lines)
M	chrome/browser/sync/engine/auth_watcher.h	View	2 chunks	+3 lines, -5 lines	0 comments
M	chrome/browser/sync/engine/auth_watcher.cc	View	8 chunks	+16 lines, -32 lines	0 comments
M	chrome/browser/sync/engine/auth_watcher_unittest.cc	View	4 chunks	+5 lines, -10 lines	0 comments
M	chrome/browser/sync/engine/authenticator.h	View	1 chunk	+3 lines, -6 lines	0 comments
M	chrome/browser/sync/engine/authenticator.cc	View	1 chunk	+2 lines, -5 lines	0 comments
M	chrome/browser/sync/engine/net/server_connection_manager.h	View	2 chunks	+0 lines, -3 lines	0 comments
M	chrome/browser/sync/engine/syncapi.cc	View	1 chunk	+1 line, -1 line	0 comments
M	chrome/browser/sync/util/user_settings.h	View	2 chunks	+0 lines, -5 lines	0 comments
M	chrome/browser/sync/util/user_settings.cc	View	5 chunks	+5 lines, -40 lines	0 comments
M	chrome/browser/sync/util/user_settings_unittest.cc	View	7 chunks	+82 lines, -3 lines	0 comments
M	chrome/common/net/gaia/gaia_authenticator.h	View	8 chunks	+10 lines, -39 lines	0 comments
M	chrome/common/net/gaia/gaia_authenticator.cc	View	7 chunks	+15 lines, -43 lines	0 comments
M	chrome/common/net/gaia/gaia_authenticator_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments
D	chrome/common/net/gaia/signin.h	View	1 chunk	+0 lines, -18 lines	0 comments
M	chrome/service/cloud_print/cloud_print_proxy_backend.cc	View	1 chunk	+2 lines, -2 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

skrul

10 years, 7 months ago (2010-05-27 16:29:18 UTC) #2

LGTM++

I love this change, a shining example on unprogramming :) :)

Expand Messages | Collapse Messages