Issue 2124010: Install the send metrics on resume script and rev the ebuilds.

Issue 2124010: Install the send metrics on resume script and rev the ebuilds. (Closed)

Created:
10 years, 7 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
Sameer Nanda

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, rtc, awong, adlr, Chris Masone

Base URL:
ssh://git@chromiumos-git/chromiumos-overlay.git

Visibility:
Public.

Description

Install the send metrics on resume script and rev the ebuilds.

Patch Set 2 : Address review comments. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-2 lines, --3 lines)			Patch
A +	chromeos-base/chromeos-acpi/chromeos-acpi-0.0.1-r3.ebuild	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chromeos-base/chromeos-init/chromeos-init-0.0.1-r35.ebuild	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chromeos-base/power_manager/power_manager-9999.ebuild	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	chromeos-base/power_manager/power_manager-9999-r6.ebuild	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

petkov

Not sure if the location of the send_metrics_on_resume script is OK. Open to suggestions. Related ...

10 years, 7 months ago (2010-05-19 17:34:18 UTC) #1

Sameer Nanda

please rename the existing ebuilds instead of adding new ones. helps keep the clutter down. ...

10 years, 7 months ago (2010-05-19 17:38:53 UTC) #2

petkov

A+ means that I've renamed the symlinks. PTAL. http://codereview.chromium.org/2124010/diff/1/3 File chromeos-base/chromeos-acpi/chromeos-acpi-0.0.1.ebuild (right): http://codereview.chromium.org/2124010/diff/1/3#newcode35 chromeos-base/chromeos-acpi/chromeos-acpi-0.0.1.ebuild:35: doexe ...

10 years, 7 months ago (2010-05-19 18:13:18 UTC) #3

LGTM

Expand Messages | Collapse Messages