Issue 21223: Add test to check that FDs are sent through the OS X Sandbox ok.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21223: Add test to check that FDs are sent through the OS X Sandbox ok. (Closed)

Created:
11 years, 10 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add test to check that FDs are sent through the OS X Sandbox ok.

Patch Set 1 #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -30 lines)			Patch
M	chrome/chrome.xcodeproj/project.pbxproj	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/ipc_send_fds_test.cc	View	4 chunks	+106 lines, -30 lines	2 comments	Download
M	chrome/common/ipc_tests.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/ipc_tests.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

11 years, 10 months ago (2009-02-10 20:54:29 UTC) #2

LGTM

http://codereview.chromium.org/21223/diff/1/3
File chrome/common/ipc_send_fds_test.cc (right):

http://codereview.chromium.org/21223/diff/1/3#newcode4
Line 4: 
Perhaps add the bug name to the top of this file for clarity:
"Add test to check that FDs are sent through the OS X Sandbox ok."
Will make it easier for some windows dude to know why this is here, and what to
do.

http://codereview.chromium.org/21223/diff/1/3#newcode26
Line 26: static void VerifyAndCloseDescriptor(int fd, ino_t inode_num) {
Perhaps a comment explaining why we need to compare inode.  I think the answer
is that you are confirming the fds point to the same thing, but it may be hard
to spot.

Expand Messages | Collapse Messages