Issue 2121014: Revert change 3849. On ia32, LoadFromSlot again returns its result on the to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2121014: Revert change 3849. On ia32, LoadFromSlot again returns its result on the to... (Closed)

Created:
10 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Revert change 3849. On ia32, LoadFromSlot again returns its result on the top of the expression stack, not as a Result return value. Committed: http://code.google.com/p/v8/source/detail?r=4700

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -43 lines)			Patch
	M	src/ia32/codegen-ia32.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/ia32/codegen-ia32.cc	View		10 chunks	+34 lines, -41 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Reverting this change should give slightly better code generation. This change was in preparation for ...

10 years, 7 months ago (2010-05-21 11:49:56 UTC) #1

LGTM

Expand Messages | Collapse Messages