Issue 212053: Fake main window resizing in the test shell....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212053: Fake main window resizing in the test shell.... (Closed)

Created:
11 years, 3 months ago by Nate Chapin

Modified:
9 years, 5 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fake main window resizing in the test shell. BUG=22707 TEST=window-resize layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27006

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 5

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -15 lines)			Patch
M	webkit/tools/layout_tests/test_expectations.txt	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	webkit/tools/test_shell/mac/test_webview_delegate.mm	View		1 chunk	+4 lines, -3 lines	1 comment	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	1 2	3 chunks	+14 lines, -1 line	2 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate_gtk.cc	View		2 chunks	+4 lines, -2 lines	1 comment	Download
M	webkit/tools/test_shell/test_webview_delegate_win.cc	View	1	2 chunks	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dglazkov

11 years, 3 months ago (2009-09-23 18:17:14 UTC) #2

LGTM with comments:

http://codereview.chromium.org/212053/diff/1005/1008
File webkit/tools/test_shell/mac/test_webview_delegate.mm (right):

http://codereview.chromium.org/212053/diff/1005/1008#newcode125
Line 125: } else if (WebWidgetHost* host = GetWidgetHost()) {
Early return, no need to use else if, right?

http://codereview.chromium.org/212053/diff/1005/1011
File webkit/tools/test_shell/test_webview_delegate.h (right):

http://codereview.chromium.org/212053/diff/1005/1011#newcode313
Line 313: // the main window, the passed inWebRect is saved as fake_rect_ and we
return
... passed in WebRect ...

http://codereview.chromium.org/212053/diff/1005/1011#newcode317
Line 317: void setFakeWindowRect(const WebKit::WebRect&);
these could be just straight accessor-style
fake_window_rect()/set_fake_window_rect() methods.

http://codereview.chromium.org/212053/diff/1005/1007
File webkit/tools/test_shell/test_webview_delegate_gtk.cc (right):

http://codereview.chromium.org/212053/diff/1005/1007#newcode173
Line 173: } else if (WebWidgetHost* host = GetWidgetHost()) {
Ditto on early return.

http://codereview.chromium.org/212053/diff/1005/1010
File webkit/tools/test_shell/test_webview_delegate_win.cc (right):

http://codereview.chromium.org/212053/diff/1005/1010#newcode99
Line 99: } else if (WebWidgetHost* host = GetWidgetHost()) {
Ditto on early return.

Expand Messages | Collapse Messages