Issue 212046: Linux: correctly update window restore bounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212046: Linux: correctly update window restore bounds. (Closed)

Created:
11 years, 3 months ago by Mike Mammarella

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, mattm

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux: correctly update window restore bounds. This makes creating a new window after maximizing an existing window work as intended (reliably). BUG=15102 TEST=create a new window after maximizing an existing window on sawfish; the new window should not be maximized Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26821

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	chrome/browser/gtk/browser_window_gtk.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM I'd like to see some tests for this behavior. It seems *really* subtle.

11 years, 3 months ago (2009-09-22 01:16:03 UTC) #2

mattm

11 years, 3 months ago (2009-09-22 04:52:12 UTC) #3

Cool, patched in and tested locally.  Thanks for fixing

On 2009/09/22 01:12:50, Mike Mammarella wrote:
>

Expand Messages | Collapse Messages