Issue 212042: WebKit merge 48585:48610

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212042: WebKit merge 48585:48610 (Closed)

Created:
11 years, 3 months ago by Paul Godavari

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

WebKit merge 48585:48610. BUG=None. TEST=Covered by layout tests.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	DEPS	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/tools/layout_tests/test_expectations.txt	View	1 2 3 4	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dglazkov

11 years, 3 months ago (2009-09-22 03:59:20 UTC) #2

I apologize for being such a nit-picker.

LGTM after these edits:

http://codereview.chromium.org/212042/diff/3001/3002
File webkit/tools/layout_tests/test_expectations.txt (right):

http://codereview.chromium.org/212042/diff/3001/3002#newcode2195
Line 2195: BUG22299 : LayoutTests/fast/dom/Window/window-property-shadowing.html
= FAIL PASS
I am pretty sure Nate fixed this in http://trac.webkit.org/changeset/48598, so
we should just remove this line and mark the bug as fixed. Marking is test as
flaky dooms it for 400 bot runs. It ain't a good thing.

http://codereview.chromium.org/212042/diff/3001/3002#newcode2336
Line 2336: BUG22576 WIN : LayoutTests/media/restore-from-page-cache.html =
TIMEOUT
This should be WONTFIX SKIP BUG19635 and up with the others with the same bug --
we don't support pageshow/pagehide events, since we don't use back/forward
cache.

Expand Messages | Collapse Messages