Changed selenium tests to recover from test crashes/hangs. Divided perceptual...

Changed selenium tests to recover from test crashes/hangs. Divided perceptual diff tests into unit test cases, which can be run alongside the selenium tests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27092

[Greg Spencer, 2009-09-21 23:48:18]

http://codereview.chromium.org/212031/diff/3005/6008
File tests/selenium/javascript_unit_test_list.txt (right):

http://codereview.chromium.org/212031/diff/3005/6008#newcode99
Line 99: large   TestStressCullingZSort pdiff_threshold(450) screenshot
screenshot screenshot screenshot screenshot screenshot screenshot screenshot
Can't you make "screenshot" take an argument for how many to do, instead of just
repeating it?

http://codereview.chromium.org/212031/diff/3005/6011
File tests/selenium/pdiff_test.py (right):

http://codereview.chromium.org/212031/diff/3005/6011#newcode1
Line 1: import os
Please add a copyright statement to this file.

http://codereview.chromium.org/212031/diff/3005/6011#newcode80
Line 80: self.fail('Reference image for ' + self.screenshot_name + ' not found.'
+
Line longer than 80 chars.

[bradn, 2009-09-22 06:05:11]

http://codereview.chromium.org/212031/diff/3005/6010
File tests/selenium/javascript_unit_tests.py (right):

http://codereview.chromium.org/212031/diff/3005/6010#newcode53
Line 53: sample_path=None,  options=None):
nix the extra space after the comma while you're here...

http://codereview.chromium.org/212031/diff/3005/6007
File tests/selenium/main.py (right):

http://codereview.chromium.org/212031/diff/3005/6007#newcode138
Line 138: 
I believe this space is suppose to be here.

http://codereview.chromium.org/212031/diff/3005/6007#newcode162
Line 162: END_PORT = 8150
This might break pulse, I think only the smaller range of ports is open on the
agents. I guess if you log onto them and change it this is fine.

http://codereview.chromium.org/212031/diff/3005/6007#newcode609
Line 609: 
Needs and extra line.

http://codereview.chromium.org/212031/diff/3005/6007#newcode686
Line 686: if type(entry).__name__ == 'tuple':
--> if type(entry) == tuple:

http://codereview.chromium.org/212031/diff/3005/6007#newcode697
Line 697: if type(entry).__name__ == 'tuple':
--> if type(entry) == tuple:

http://codereview.chromium.org/212031/diff/3005/6007#newcode721
Line 721: shutdown_session.shut_down_selenium_server()
I'd use "http://%s:%d" % (socket.gethostname(), http_server.http_port) here.

http://codereview.chromium.org/212031/diff/3005/6011
File tests/selenium/pdiff_test.py (right):

http://codereview.chromium.org/212031/diff/3005/6011#newcode13
Line 13: def __init__(self, name, num_screenshots, screenshot_name, pdiff_path,
Insert line above.

http://codereview.chromium.org/212031/diff/3005/6009
File tests/selenium/samples_tests.py (right):

http://codereview.chromium.org/212031/diff/3005/6009#newcode317
Line 317: s, self.browser, "g_client", ("shader-test%d" % (shader + 1))))
You can drop one layer of parens here.

[Ken Kania, 2009-09-23 23:34:29]

Various minor changes and tweaks.

[bradn, 2009-09-23 23:36:44]

Other than that LGTM

http://codereview.chromium.org/212031/diff/16005/18011
File tests/selenium/pdiff_test.py (right):

http://codereview.chromium.org/212031/diff/16005/18011#newcode81
Line 81: self.fail('Reference image for ' + self.screenshot_name + ' not found.'
+
>80

http://codereview.chromium.org/212031/diff/16005/18003
File tests/selenium/test_runner.py (right):

http://codereview.chromium.org/212031/diff/16005/18003#newcode391
Line 391: 
extra lines??