Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 212028: suppression update (Closed)

Created:
11 years, 3 months ago by dank
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, Timur Iskhodzhanov, dank, stuartmorgan, pam+watch_chromium.org
Visibility:
Public.

Description

Restore a suppression that only seems to happen on some machines, add a couple new suppressions, widen a couple others, all found on a -O1 -fno-inlining big-redzone fishing expedition on mac 'caliban'. BUG=11134, 20541, 20459, 20653, 22450, 22519 TEST="sh tools/valgrind/shard-all-tests.sh base_unittests net_unittests ui_tests unit_tests" on mac pro overnight Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26851

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -4 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 2 chunks +21 lines, -0 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 4 chunks +65 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dank
This seems to be the main fallout from testing with the cflags patch (and from ...
11 years, 3 months ago (2009-09-20 22:43:15 UTC) #1
stuartmorgan
LGTM
11 years, 3 months ago (2009-09-21 16:37:08 UTC) #2
dank
Added three more from caliban last night.
11 years, 3 months ago (2009-09-21 18:08:18 UTC) #3
stuartmorgan
11 years, 3 months ago (2009-09-21 18:32:42 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698