Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 212021: Move the --type=plugin and --plugin-path args to the beginning of the arg list for plugin processes. (Closed)

Created:
11 years, 3 months ago by Mike Mammarella
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, Evan Stade
CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam, Ben Goodger (Google)
Visibility:
Public.

Description

Move the --type=plugin and --plugin-path arguments to the beginning of the argument list for plugin processes. BUG=22262 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/plugin_process_host.cc View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike Mammarella
11 years, 3 months ago (2009-09-18 20:34:16 UTC) #1
Evan Martin
Does this make them show up in top? I like the idea...
11 years, 3 months ago (2009-09-18 20:38:02 UTC) #2
Mike Mammarella
On 2009/09/18 20:38:02, Evan Martin wrote: > Does this make them show up in top? ...
11 years, 3 months ago (2009-09-18 20:41:52 UTC) #3
Evan Stade
lgtm for consistency
11 years, 3 months ago (2009-09-18 21:12:06 UTC) #4
Evan Martin
11 years, 3 months ago (2009-09-18 21:18:30 UTC) #5
LGTM too then, we can ask bradfitz on the bug if he's satisfied with this.  :)

Powered by Google App Engine
This is Rietveld 408576698