Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: command_buffer/common/cross/buffer_sync_api.h

Issue 212018: Change command buffer client code to use structures.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/o3d/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: command_buffer/common/cross/buffer_sync_api.h
===================================================================
--- command_buffer/common/cross/buffer_sync_api.h (revision 26638)
+++ command_buffer/common/cross/buffer_sync_api.h (working copy)
@@ -49,21 +49,21 @@
class BufferSyncInterface {
public:
// Status of the command buffer service. It does not process commands
- // (meaning: get will not change) unless in PARSING state.
+ // (meaning: get will not change) unless in kParsing state.
enum ParserStatus {
- NOT_CONNECTED, // The service is not connected - initial state.
- NO_BUFFER, // The service is connected but no buffer was set.
- PARSING, // The service is connected, and parsing commands from the
+ kNotConnected, // The service is not connected - initial state.
+ kNoBuffer, // The service is connected but no buffer was set.
+ kParsing, // The service is connected, and parsing commands from the
// buffer.
- PARSE_ERROR, // Parsing stopped because a parse error was found.
+ kParseError, // Parsing stopped because a parse error was found.
};
enum ParseError {
- PARSE_NO_ERROR,
- PARSE_INVALID_SIZE,
- PARSE_OUT_OF_BOUNDS,
- PARSE_UNKNOWN_COMMAND,
- PARSE_INVALID_ARGUMENTS,
+ kParseNoError,
+ kParseInvalidSize,
+ kParseOutOfBounds,
+ kParseUnknownCommand,
+ kParseInvalidArguments,
};
// Invalid shared memory Id, returned by RegisterSharedMemory in case of
@@ -155,8 +155,8 @@
// Gets the current parse error. The current parse error is set when the
// service is in the PARSE_ERROR status. It may also be set while in the
- // PARSING state, if a recoverable error (like PARSE_UNKNOWN_METHOD) was
- // encountered. Getting the error resets it to PARSE_NO_ERROR.
+ // kParsing state, if a recoverable error (like PARSE_UNKNOWN_METHOD) was
+ // encountered. Getting the error resets it to kParseNoError.
// Returns:
// The current parse error.
virtual ParseError GetParseError() = 0;
« no previous file with comments | « command_buffer/client/cross/fenced_allocator_test.cc ('k') | command_buffer/common/cross/cmd_buffer_format.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698