Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: command_buffer/service/cross/gapi_decoder.h

Issue 212018: Change command buffer client code to use structures.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/o3d/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « command_buffer/service/cross/effect_utils.h ('k') | command_buffer/service/cross/gapi_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: command_buffer/service/cross/gapi_decoder.h
===================================================================
--- command_buffer/service/cross/gapi_decoder.h (revision 26638)
+++ command_buffer/service/cross/gapi_decoder.h (working copy)
@@ -52,14 +52,8 @@
explicit GAPIDecoder(GAPIInterface *gapi) : gapi_(gapi), engine_(NULL) {}
virtual ~GAPIDecoder() {}
- // Executes a command.
- // Parameters:
- // command: the command index.
- // arg_count: the number of CommandBufferEntry arguments.
- // args: the arguments.
- // Returns:
- // BufferSyncInterface::NO_ERROR if no error was found, one of
- // BufferSyncInterface::ParseError otherwise.
+
+ // Overridden from AsyncAPIInterface.
virtual ParseError DoCommand(unsigned int command,
unsigned int arg_count,
const void* args);
@@ -68,46 +62,6 @@
// to.
void set_engine(CommandBufferEngine *engine) { engine_ = engine; }
private:
- // Decodes the SET_VERTEX_INPUT command.
- ParseError DecodeSetVertexInput(unsigned int arg_count,
- CommandBufferEntry *args);
-
- // Decodes the CREATE_TEXTURE_2D command.
- ParseError DecodeCreateTexture2D(unsigned int arg_count,
- CommandBufferEntry *args);
-
- // Decodes the CREATE_TEXTURE_3D command.
- ParseError DecodeCreateTexture3D(unsigned int arg_count,
- CommandBufferEntry *args);
-
- // Decodes the CREATE_TEXTURE_CUBE command.
- ParseError DecodeCreateTextureCube(unsigned int arg_count,
- CommandBufferEntry *args);
-
- // Decodes the SET_TEXTURE_DATA command.
- ParseError DecodeSetTextureData(unsigned int arg_count,
- CommandBufferEntry *args);
-
- // Decodes the SET_TEXTURE_DATA_IMMEDIATE command.
- ParseError DecodeSetTextureDataImmediate(unsigned int arg_count,
- CommandBufferEntry *args);
-
- // Decodes the GET_TEXTURE_DATA command.
- ParseError DecodeGetTextureData(unsigned int arg_count,
- CommandBufferEntry *args);
-
- // Decodes the SET_SAMPLER_STATES command.
- ParseError DecodeSetSamplerStates(unsigned int arg_count,
- CommandBufferEntry *args);
-
- // Decodes the SET_STENCIL_TEST command.
- ParseError DecodeSetStencilTest(unsigned int arg_count,
- CommandBufferEntry *args);
-
- // Decodes the SET_BLENDING command.
- ParseError DecodeSetBlending(unsigned int arg_count,
- CommandBufferEntry *args);
-
// Gets the address of shared memory data, given a shared memory ID and an
// offset. Also checks that the size is consistent with the shared memory
// size.
@@ -125,7 +79,7 @@
// Generate a member function prototype for each command in an automated and
// typesafe way.
#define O3D_COMMAND_BUFFER_CMD_OP(name) \
- ParseError Handle_ ## name( \
+ ParseError Handle ## name( \
unsigned int arg_count, \
const cmd::name& args); \
« no previous file with comments | « command_buffer/service/cross/effect_utils.h ('k') | command_buffer/service/cross/gapi_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698