Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1495)

Unified Diff: core/cross/command_buffer/render_surface_cb.cc

Issue 212018: Change command buffer client code to use structures.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/o3d/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/cross/command_buffer/primitive_cb.cc ('k') | core/cross/command_buffer/renderer_cb.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/cross/command_buffer/render_surface_cb.cc
===================================================================
--- core/cross/command_buffer/render_surface_cb.cc (revision 26638)
+++ core/cross/command_buffer/render_surface_cb.cc (working copy)
@@ -59,17 +59,10 @@
ResourceID id = renderer_->render_surface_ids().AllocateID();
resource_id_ = id;
CommandBufferHelper *helper = renderer_->helper();
- CommandBufferEntry args[4];
- args[0].value_uint32 = id;
- args[1].value_uint32 =
- create_render_surface_cmd::Width::MakeValue(width) |
- create_render_surface_cmd::Height::MakeValue(height);
- args[2].value_uint32 =
- create_render_surface_cmd::Levels::MakeValue(mip_level) |
- create_render_surface_cmd::Side::MakeValue(side);
- args[3].value_uint32 =
- reinterpret_cast<ResourceID>(texture->GetTextureHandle());
- helper->AddCommand(command_buffer::CREATE_RENDER_SURFACE, 4, args);
+ helper->CreateRenderSurface(
+ id,
+ reinterpret_cast<uint32>(texture->GetTextureHandle()),
+ width, height, mip_level, side);
}
RenderSurfaceCB::~RenderSurfaceCB() {
@@ -80,9 +73,7 @@
// This should never be called during rendering.
if (resource_id_ != command_buffer::kInvalidResource) {
CommandBufferHelper *helper = renderer_->helper();
- CommandBufferEntry args[1];
- args[0].value_uint32 = resource_id_;
- helper->AddCommand(command_buffer::DESTROY_RENDER_SURFACE, 1, args);
+ helper->DestroyRenderSurface(resource_id_);
renderer_->render_surface_ids().FreeID(resource_id_);
resource_id_ = command_buffer::kInvalidResource;
}
@@ -102,20 +93,13 @@
ResourceID id = renderer_->depth_surface_ids().AllocateID();
resource_id_ = id;
CommandBufferHelper *helper = renderer_->helper();
- CommandBufferEntry args[2];
- args[0].value_uint32 = id;
- args[1].value_uint32 =
- create_render_surface_cmd::Width::MakeValue(width) |
- create_render_surface_cmd::Height::MakeValue(height);
- helper->AddCommand(command_buffer::CREATE_DEPTH_SURFACE, 2, args);
+ helper->CreateDepthSurface(id, width, height);
}
void RenderDepthStencilSurfaceCB::Destroy() {
if (resource_id_ != command_buffer::kInvalidResource) {
CommandBufferHelper *helper = renderer_->helper();
- CommandBufferEntry args[1];
- args[0].value_uint32 = resource_id_;
- helper->AddCommand(command_buffer::DESTROY_DEPTH_SURFACE, 1, args);
+ helper->DestroyDepthSurface(resource_id_);
renderer_->depth_surface_ids().FreeID(resource_id_);
resource_id_ = command_buffer::kInvalidResource;
}
« no previous file with comments | « core/cross/command_buffer/primitive_cb.cc ('k') | core/cross/command_buffer/renderer_cb.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698