Issue 212017: Fix expat.gyp to build on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212017: Fix expat.gyp to build on Linux (Closed)

Created:
11 years, 3 months ago by Zachary Kuznia

Modified:
9 years, 7 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix expat.gyp to build on Linux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26585

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	third_party/expat/expat.gyp	View		2 chunks	+13 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

11 years, 3 months ago (2009-09-18 14:19:08 UTC) #2

LGTM

http://codereview.chromium.org/212017/diff/1/2
File third_party/expat/expat.gyp (right):

http://codereview.chromium.org/212017/diff/1/2#newcode45
Line 45: 'defines' : [
no space before the colon.

Expand Messages | Collapse Messages