Issue 21190: POSIX: add command line option to launch renderers in a wrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21190: POSIX: add command line option to launch renderers in a wrapper (Closed)

Created:
11 years, 10 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

POSIX: add command line option to launch renderers in a wrapper For example, ./Hammer/chrome --renderer-cmd-prefix="gdb --args"

Patch Set 1 #

Total comments: 2

Patch Set 2 : addresssing comments #

Patch Set 3 : ... #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
M	base/command_line.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	base/command_line.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	1 2	2 chunks	+16 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 10 months ago (2009-02-09 22:45:43 UTC) #2

http://codereview.chromium.org/21190/diff/1/3
File base/command_line.h (right):

http://codereview.chromium.org/21190/diff/1/3#newcode118
Line 118: // "valgrind" or "gdb --args")
"only available on POSIX" or something

http://codereview.chromium.org/21190/diff/1/5
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/21190/diff/1/5#newcode374
Line 374: const wchar_t kRendererCmdPrefix[]             =
L"renderer-cmd-prefix";
doc this flag here (people use this file as the effective flag reference)

Expand Messages | Collapse Messages