Disable battery power detection on POSIX since we don't currently use it.

Disable battery power detection on POSIX since we don't currently use it.
Batter Power is used on Windows to toggle HiRest timers, but this isn't applicable on other platforms.

[jeremy, 2009-02-09 22:14:45]

Mike: Is the underlying assumption of this CL correct.
jrg/evan: general lgtm since this touches Mac/Linux.

[Evan Martin, 2009-02-09 22:17:25]

+craig since his change is related

As I said on IRC, it seems odd to me to preemptively remove this.  You might get
fewer ifdefs if you leave most of the code alone and just ifdef out the bodies
of the implementation functions.

[John Grabowski, 2009-02-09 22:31:43]

On 2009/02/09 22:17:25, Evan Martin wrote:
> +craig since his change is related
> 
> As I said on IRC, it seems odd to me to preemptively remove this.  You might
get
> fewer ifdefs if you leave most of the code alone and just ifdef out the bodies
> of the implementation functions.

I agree with this sentiment.  Perhaps, instead of ifdefs, we could use other
techniques?  E.g. a virtual function called IsPowerCheckNeeded() to make it more
clear the BatteryPower() routines may not be called on some platforms.

[Mike Belshe, 2009-02-09 23:03:02]

I agree with others that I don't like the ifdef approach; the
system_monitor.h/cpp should be reasonably cross-platform.

Perhaps we want a flag to enable/disable the system monitor, and that could be
controlled by an ifdef.  But overall, the code should benign; unless its really
causing issues, maybe just leave it alone?

[John Grabowski, 2009-02-09 23:25:30]

LGTM, but wait for comments by others who may have stronger opinions.

http://codereview.chromium.org/21187/diff/3010/20
File base/system_monitor.cc (right):

http://codereview.chromium.org/21187/diff/3010/20#newcode11
Line 11: #if defined(ENABLE_BATTERY_MONITORING)
This #ifdef is probably unnecessary.

http://codereview.chromium.org/21187/diff/3010/21
File base/system_monitor.h (right):

http://codereview.chromium.org/21187/diff/3010/21#newcode37
Line 37: static void Start();
Add a comment that, at this time, Start() may be a nop on some platforms.

[jeremy, 2009-02-09 23:30:49]

New snapshot uploaded.

http://codereview.chromium.org/21187/diff/3010/20
File base/system_monitor.cc (right):

http://codereview.chromium.org/21187/diff/3010/20#newcode11
Line 11: #if defined(ENABLE_BATTERY_MONITORING)
gcc yells if I don't do this since the constant isn't used...

http://codereview.chromium.org/21187/diff/3010/21
File base/system_monitor.h (right):

http://codereview.chromium.org/21187/diff/3010/21#newcode37
Line 37: static void Start();
On 2009/02/09 23:25:30, John Grabowski wrote:
> Add a comment that, at this time, Start() may be a nop on some platforms.

Done.

[Evan Martin, 2009-02-09 23:34:03]

looks fine to me.  i leave it to mbelshe for final lgtm.

[Mike Belshe, 2009-02-10 00:36:45]

lgtm

[Craig Schlenter, 2009-02-10 04:37:21]

On 2009/02/09 22:17:25, Evan Martin wrote:
> +craig since his change is related

My change was done blindly, sorry - I should have checked to see how the code
was being used first. This change looks good...