third_party/WebKit/WebCore/page/ContextMenuController.cpp - Issue 21184: WebKit merge 40722:40785 (part 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/WebCore/page/ContextMenuController.cpp

Issue 21184: WebKit merge 40722:40785 (part 1) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 11 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/WebCore/page/ContextMenuController.cpp

===================================================================

--- third_party/WebKit/WebCore/page/ContextMenuController.cpp (revision 9391)

+++ third_party/WebKit/WebCore/page/ContextMenuController.cpp (working copy)

@@ -193,7 +193,7 @@

#endif

case ContextMenuItemTagSpellingGuess:

ASSERT(frame->selectedText().length());

- if (frame->editor()->shouldInsertText(item->title(), frame->selection()->toRange().get(),

+ if (frame->editor()->shouldInsertText(item->title(), frame->selection()->toNormalizedRange().get(),

EditorInsertActionPasted)) {

Document* document = frame->document();

RefPtr<ReplaceSelectionCommand> command =

@@ -238,7 +238,7 @@

break;

case ContextMenuItemTagStartSpeaking: {

ExceptionCode ec;

- RefPtr<Range> selectedRange = frame->selection()->toRange();

+ RefPtr<Range> selectedRange = frame->selection()->toNormalizedRange();

if (!selectedRange || selectedRange->collapsed(ec)) {

Document* document = result.innerNonSharedNode()->document();

selectedRange = document->createRange();