Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 21174: alternateFamilyName customization for Windows was landed in Webkit (r40636, h... (Closed)

Created:
11 years, 10 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

alternateFamilyName customization for Windows was landed in Webkit (r40636, https://bugs.webkit.org/show_bug.cgi?id=20531). Instead of adding a static member function to FontCache class to be implemented in each platform, |alternateFamilyName| in FontCache.cpp was changed with #ifdef's for Windows. This CL make our copy of FontCache.h identical to that of Webkit trunk's. FontCache.cpp was merged in the latest merge. It also removes the implementation of alternateFamilyName in FontCache{ChromiumWin,Linux}.cpp. This part of the patch was uploaded to webkit bug 20531 (https://bugs.webkit.org/attachment.cgi?id=27486 ) FontCacheChromiumWin.cpp also includes a patch for off-by-1 error (webkit bug : http://bugs.webkit.org/show_bug.cgi?id=23803). This was not intended, but the fix is trivial and I'll land it together once the webkit trunk gets it. BUG=7549 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -52 lines) Patch
M third_party/WebKit/WebCore/platform/graphics/FontCache.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp View 1 chunk +6 lines, -41 lines 0 comments Download
M third_party/WebKit/WebCore/platform/graphics/chromium/FontCacheLinux.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
11 years, 10 months ago (2009-02-09 18:44:10 UTC) #1
dglazkov
11 years, 10 months ago (2009-02-09 19:41:34 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698