Issue 2115013: Roll gyp DEPS to 826 to include my makefile changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2115013: Roll gyp DEPS to 826 to include my makefile changes. (Closed)

Created:
10 years, 7 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, bradnelson, Michael Moss, bradn

CC:
chromium-reviews

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Roll gyp DEPS to 826 to include my makefile changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48814

Patch Set 1 #

Patch Set 2 : stig #

Patch Set 3 : 826 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tony

Brad: This broke the windows build. Can you fix? _______ running 'C:\b\depot_tools\python_bin\python.exe src/build/gyp_chromium' in 'C:\b\slave\chromium-rel-builder\build' ...

10 years, 7 months ago (2010-05-25 00:36:10 UTC) #4

tony

Turns out it was lei's change that broke windows. I'm going to resubmit this patch ...

10 years, 6 months ago (2010-06-03 05:02:59 UTC) #5

LGTM

Expand Messages | Collapse Messages