Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2112743002: Move Mojo bots to chromium_fyi; remove mojo master. (Closed)

Created:
4 years, 5 months ago by msw
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, sky
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Move Mojo bots to chromium_fyi; remove mojo master. Remove unused chromium_mojo "Chromium Mojo Android". Move chromium_mojo "Chromium Mojo Windows" to chromium_fyi "Mojo Windows". Move chromium_mojo "Chromium Mojo Linux" to chromium_fyi "Mojo ChromiumOS". (we now need fyi build/test coverage on chrome os, not desktop linux) Move required slave configs; remove chromium_mojo master references. Run "scripts/slave/unittests/recipe_simulation_test.py train" This CL will be accompanied by: https://codereview.chromium.org/2114453002 BUG=619128 TEST=Chromium Mojo bots move to Chromium FYI master. R=dpranke@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/71d600393f83c9b4ba693edbf61e79097db9a471

Patch Set 1 #

Patch Set 2 : Remove more master references; run recipe training. #

Total comments: 3

Patch Set 3 : Add 'use_isolate': True and 'enable_swarming': True. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -1173 lines) Patch
M masters/master.chromium.fyi/master.cfg View 3 chunks +21 lines, -1 line 0 comments Download
M masters/master.chromium.fyi/slaves.cfg View 1 chunk +16 lines, -0 lines 0 comments Download
D masters/master.chromium.mojo/Makefile View 1 chunk +0 lines, -12 lines 0 comments Download
D masters/master.chromium.mojo/buildbot View 1 chunk +0 lines, -15 lines 0 comments Download
D masters/master.chromium.mojo/buildbot.tac View 1 chunk +0 lines, -20 lines 0 comments Download
D masters/master.chromium.mojo/builders.pyl View 1 chunk +0 lines, -59 lines 0 comments Download
D masters/master.chromium.mojo/master.cfg View 1 chunk +0 lines, -26 lines 0 comments Download
D masters/master.chromium.mojo/master_site_config.py View 1 chunk +0 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/builders.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
D scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py View 1 chunk +0 lines, -71 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_fyi_Mojo_ChromiumOS.json View 1 2 5 chunks +10 lines, -11 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_fyi_Mojo_Windows.json View 1 2 4 chunks +9 lines, -10 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_mojo_Chromium_Mojo_Android.json View 1 chunk +0 lines, -329 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_mojo_Chromium_Mojo_Linux.json View 1 chunk +0 lines, -293 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_mojo_Chromium_Mojo_Windows.json View 1 chunk +0 lines, -301 lines 0 comments Download
M tests/masters_test.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
msw
Hey Dirk, please take a careful look; thanks! (Am I doing this right? Can I ...
4 years, 5 months ago (2016-06-29 23:14:59 UTC) #3
Dirk Pranke
On 2016/06/29 23:14:59, msw wrote: > Hey Dirk, please take a careful look; thanks! > ...
4 years, 5 months ago (2016-06-29 23:23:49 UTC) #4
msw
On 2016/06/29 23:23:49, Dirk Pranke wrote: > w/ nit addressed. I don't see a nit, ...
4 years, 5 months ago (2016-06-30 00:03:16 UTC) #5
Dirk Pranke
Odd, I don't know why that didn't get published before ... https://codereview.chromium.org/2112743002/diff/20001/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right): ...
4 years, 5 months ago (2016-06-30 00:12:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112743002/40001
4 years, 5 months ago (2016-06-30 01:43:42 UTC) #10
msw
https://codereview.chromium.org/2112743002/diff/20001/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right): https://codereview.chromium.org/2112743002/diff/20001/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py#newcode2288 scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:2288: 'Mojo ChromiumOS': { On 2016/06/30 00:12:04, Dirk Pranke wrote: ...
4 years, 5 months ago (2016-06-30 01:45:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112743002/40001
4 years, 5 months ago (2016-06-30 03:06:45 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 03:11:26 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/71d600393f83c9b4ba69...

Powered by Google App Engine
This is Rietveld 408576698