Issue 2112013: Start generating a bootable kernel partition as part of build_image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2112013: Start generating a bootable kernel partition as part of build_image (Closed)

Created:
10 years, 7 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler, Louis

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

Start generating a bootable kernel partition as part of build_image Modify build_image to use the create_blob utility and the inline bootloader to generate a bootable (but still unsigned) kernel partition.

Patch Set 1 #

Total comments: 4

Patch Set 2 : respond to feedback #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -5 lines)			Patch
	M	src/scripts/build_image	View	1	2 chunks	+26 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

LGTM with suggestion on comments. http://codereview.chromium.org/2112013/diff/1/2 File src/scripts/build_image (right): http://codereview.chromium.org/2112013/diff/1/2#newcode423 src/scripts/build_image:423: earlyprintk=serial,ttyS0,115200 I assume we'll ...

10 years, 7 months ago (2010-05-21 18:40:08 UTC) #2

Bill Richardson

http://codereview.chromium.org/2112013/diff/1/2 File src/scripts/build_image (right): http://codereview.chromium.org/2112013/diff/1/2#newcode423 src/scripts/build_image:423: earlyprintk=serial,ttyS0,115200 On 2010/05/21 18:40:08, Randall Spangler wrote: > I ...

10 years, 7 months ago (2010-05-21 21:32:01 UTC) #3

lgtm

Expand Messages | Collapse Messages