Cleaned up some constants for stats reading

- Made the writing of boot times happen on the file thread.
- Also combined two different ways of writing these times into
common code.
- Tweaked the color / font of the output

BUG=NONE
TEST=Ensure that boot times still display on login screen.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47682

[Nikita (slow), 2010-05-17 07:40:06]

http://codereview.chromium.org/2112006/diff/11/4003
File chrome/browser/chromeos/boot_times_loader.cc (right):

http://codereview.chromium.org/2112006/diff/11/4003#newcode165
chrome/browser/chromeos/boot_times_loader.cc:165: RecordStats("chrome-main",
chrome_main_stats_);
kChromeMain

http://codereview.chromium.org/2112006/diff/11/4004
File chrome/browser/chromeos/boot_times_loader.h (right):

http://codereview.chromium.org/2112006/diff/11/4004#newcode47
chrome/browser/chromeos/boot_times_loader.h:47: typedef struct Stats {
Please add comment how Stats is used.

http://codereview.chromium.org/2112006/diff/11/4004#newcode68
chrome/browser/chromeos/boot_times_loader.h:68: static void
RecordCurrentStats(const std::string& name);
Would be great to have an example how custom stats could be recorded/accessed
later.

http://codereview.chromium.org/2112006/diff/11/4004#newcode73
chrome/browser/chromeos/boot_times_loader.h:73: static void RecordStats(const
std::string& name, const Stats& stats);
Seems that it could private.

http://codereview.chromium.org/2112006/diff/11/4004#newcode76
chrome/browser/chromeos/boot_times_loader.h:76: static Stats GetCurrentStats();
Private?

http://codereview.chromium.org/2112006/diff/11/4005
File chrome/browser/chromeos/browser_notification_observers.cc (right):

http://codereview.chromium.org/2112006/diff/11/4005#newcode32
chrome/browser/chromeos/browser_notification_observers.cc:32:
BootTimesLoader::RecordCurrentStats("chrome-first-render");
I couldn't find where this and "login-successful" are used.

May be it makes sense to introduce constant for such custom stat names so that
it would be used when accessing these stats later.

[DaveMoore, 2010-05-18 17:44:36]

http://codereview.chromium.org/2112006/diff/11/4003
File chrome/browser/chromeos/boot_times_loader.cc (right):

http://codereview.chromium.org/2112006/diff/11/4003#newcode165
chrome/browser/chromeos/boot_times_loader.cc:165: RecordStats("chrome-main",
chrome_main_stats_);
On 2010/05/17 07:40:07, Nikita Kostylev wrote:
> kChromeMain

Done.

http://codereview.chromium.org/2112006/diff/11/4004
File chrome/browser/chromeos/boot_times_loader.h (right):

http://codereview.chromium.org/2112006/diff/11/4004#newcode47
chrome/browser/chromeos/boot_times_loader.h:47: typedef struct Stats {
I've made all the Stats stuff private.
On 2010/05/17 07:40:07, Nikita Kostylev wrote:
> Please add comment how Stats is used.

http://codereview.chromium.org/2112006/diff/11/4004#newcode68
chrome/browser/chromeos/boot_times_loader.h:68: static void
RecordCurrentStats(const std::string& name);
They're for external consumption by our boot metrics code in cros. I'm not sure
what else I would say.
On 2010/05/17 07:40:07, Nikita Kostylev wrote:
> Would be great to have an example how custom stats could be recorded/accessed
> later.

http://codereview.chromium.org/2112006/diff/11/4004#newcode73
chrome/browser/chromeos/boot_times_loader.h:73: static void RecordStats(const
std::string& name, const Stats& stats);
On 2010/05/17 07:40:07, Nikita Kostylev wrote:
> Seems that it could private.

Done.

http://codereview.chromium.org/2112006/diff/11/4004#newcode76
chrome/browser/chromeos/boot_times_loader.h:76: static Stats GetCurrentStats();
On 2010/05/17 07:40:07, Nikita Kostylev wrote:
> Private?

Done.

http://codereview.chromium.org/2112006/diff/11/4005
File chrome/browser/chromeos/browser_notification_observers.cc (right):

http://codereview.chromium.org/2112006/diff/11/4005#newcode32
chrome/browser/chromeos/browser_notification_observers.cc:32:
BootTimesLoader::RecordCurrentStats("chrome-first-render");
They're not used in chrome...they're for measuring these times externally.
On 2010/05/17 07:40:07, Nikita Kostylev wrote:
> I couldn't find where this and "login-successful" are used.
> 
> May be it makes sense to introduce constant for such custom stat names so that
> it would be used when accessing these stats later.

[Nikita (slow), 2010-05-18 20:33:04]

LGTM

http://codereview.chromium.org/2112006/diff/11/4004
File chrome/browser/chromeos/boot_times_loader.h (right):

http://codereview.chromium.org/2112006/diff/11/4004#newcode68
chrome/browser/chromeos/boot_times_loader.h:68: static void
RecordCurrentStats(const std::string& name);
I see. Initially I thought that one could register such custom stats and use it
later from Chrome.