Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2311)

Unified Diff: chrome/browser/extensions/extension_tabs_module.h

Issue 2111010: fix chrome.tabs.onUpdated bugs, add browsertest (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: more cr changes Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_module.h
diff --git a/chrome/browser/extensions/extension_tabs_module.h b/chrome/browser/extensions/extension_tabs_module.h
index 8e8298100ed05bc023da1175a3975fc07c456962..432ee22aaea807418b307e5f8c3fedaeea1d9868 100644
--- a/chrome/browser/extensions/extension_tabs_module.h
+++ b/chrome/browser/extensions/extension_tabs_module.h
@@ -21,17 +21,9 @@ class TabStripModel;
class ExtensionTabUtil {
public:
- // Possible tab states. These states are used to calculate the "status"
- // property of the Tab object that is used in the extension tab API.
- enum TabStatus {
- TAB_LOADING, // Waiting for the DOM to load.
- TAB_COMPLETE // Tab loading and rendering is complete.
- };
-
static int GetWindowId(const Browser* browser);
static int GetTabId(const TabContents* tab_contents);
- static TabStatus GetTabStatus(const TabContents* tab_contents);
- static std::string GetTabStatusText(TabStatus status);
+ static std::string GetTabStatusText(bool is_loading);
static int GetWindowIdOfTab(const TabContents* tab_contents);
static ListValue* CreateTabList(const Browser* browser);
static DictionaryValue* CreateTabValue(const TabContents* tab_contents);
« no previous file with comments | « chrome/browser/extensions/extension_tabs_apitest.cc ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698