fix chrome.tabs.onUpdated bugs, add browsertest

chrome/browser/extensions/extension_browser_event_router.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_BROWSER_EVENT_ROUTER_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_BROWSER_EVENT_ROUTER_H_
 
 #include <map>
 #include <string>
 
@@ skipping 97 matching lines @@
   //  - distinguish between tab creation and tab insertion
   //  - not send tab-detached after tab-removed
   //  - reduce the "noise" of TabChangedAt() when sending events to extensions
   class TabEntry {
    public:
     // Create a new tab entry whose initial state is TAB_COMPLETE.  This
     // constructor is required because TabEntry objects placed inside an
     // std::map<> by value.
     TabEntry();
 
-    // Create a new tab entry whose initial state is derived from the given
-    // tab contents.
-    explicit TabEntry(const TabContents* contents);
-
-    // Returns the current state of the tab.
-    ExtensionTabUtil::TabStatus state() const { return state_; }
-
     // Update the load state of the tab based on its TabContents.  Returns true
     // if the state changed, false otherwise.  Whether the state has changed or
     // not is used to determine if events needs to be sent to extensions during
     // processing of TabChangedAt(). This method will "hold" a state-change
     // to "loading", until the DidNavigate() method which should always follow
     // it. Returns NULL if no updates should be sent.
     DictionaryValue* UpdateLoadState(const TabContents* contents);
 
     // Indicates that a tab load has resulted in a navigation and the
     // destination url is available for inspection. Returns NULL if no updates
     // should be sent.
     DictionaryValue* DidNavigate(const TabContents* contents);
 
    private:
-    // Tab state used for last notification to extensions.
-    ExtensionTabUtil::TabStatus state_;
-
-    // Remember that the LOADING state has been captured, but not yet reported
-    // because it is waiting on the navigation event to know what the
-    // destination url is.
-    bool pending_navigate_;
+    // Whether we are waiting to fire the 'complete' status change. This will
+    // occur the first time the TabContents stops loading after the
+    // NAV_ENTRY_COMMITTED was fired. The tab may go back into and out of the
+    // loading state subsequently, but we will ignore those changes.
+    bool complete_waiting_on_load_;
 
     GURL url_;
   };
 
   std::map<int, TabEntry> tab_entries_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionBrowserEventRouter);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_BROWSER_EVENT_ROUTER_H_