Issue 211056: GTK: Dismiss the bookmark folder menu(s) when a context menu item is executed...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 211056: GTK: Dismiss the bookmark folder menu(s) when a context menu item is executed... (Closed)

Created:
11 years, 3 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony, Elliot Glaysher

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

GTK: Dismiss the bookmark folder menu(s) when a context menu item is executed. BUG=22372 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26890

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -7 lines)			Patch
M	chrome/browser/gtk/bookmark_context_menu.h	View	4 chunks	+12 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/bookmark_context_menu.cc	View	3 chunks	+11 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_manager_gtk.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/bookmark_menu_controller_gtk.h	View	3 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_menu_controller_gtk.cc	View	3 chunks	+8 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Evan Stade

I tried to just listen for the right signals on the menu but I couldn't ...

11 years, 3 months ago (2009-09-22 22:16:30 UTC) #1

Elliot Glaysher

Sure, what's another delegate interface at this point? LGTM. :(

11 years, 3 months ago (2009-09-22 22:19:23 UTC) #2

LGTM2