Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 211052: Implement ChromiumBridge::clipboardWritePlainText() (Closed)

Created:
11 years, 3 months ago by apavlov
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This is an implementation of the bridge method for copying arbitrary plaintext onto a clipboard in Chromium. The method is declared upstream, in a patch associated with https://bugs.webkit.org/show_bug.cgi?id=29634 TEST=copying works locally BUG=https://bugs.webkit.org/show_bug.cgi?id=29634 upstream Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27176

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 7

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M webkit/api/public/WebClipboard.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/api/src/ChromiumBridge.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/glue/webclipboard_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webclipboard_impl.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/mock_webclipboard_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/mock_webclipboard_impl.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
apavlov
Please review.
11 years, 3 months ago (2009-09-22 16:51:27 UTC) #1
pfeldman
LGTM given you rip ChromiumBridge.cpp change and run try bots on it. http://codereview.chromium.org/211052/diff/1/7 File webkit/api/src/ChromiumBridge.cpp ...
11 years, 3 months ago (2009-09-22 17:07:16 UTC) #2
darin (slow to review)
http://codereview.chromium.org/211052/diff/5002/5003 File webkit/api/public/WebClipboard.h (right): http://codereview.chromium.org/211052/diff/5002/5003#newcode64 Line 64: virtual void writePlainText(const WebString& plainText) = 0; nit: ...
11 years, 3 months ago (2009-09-22 18:39:27 UTC) #3
apavlov
http://codereview.chromium.org/211052/diff/5002/5003 File webkit/api/public/WebClipboard.h (right): http://codereview.chromium.org/211052/diff/5002/5003#newcode64 Line 64: virtual void writePlainText(const WebString& plainText) = 0; On ...
11 years, 3 months ago (2009-09-23 11:28:17 UTC) #4
darin (slow to review)
11 years, 3 months ago (2009-09-23 16:58:36 UTC) #5
thanks.  as for cleaning up the rest of mock_webclipboard_impl.{h,cc}, i think
that's best left for another CL.

Powered by Google App Engine
This is Rietveld 408576698