GDB wrapper refactoring for memcheck_analyze.py...

GDB wrapper refactoring for memcheck_analyze.py

(This changelist is prepared by Alexander Potapenko, cc'ed)
This is a small refactoring that moves the GDB querying logic into a
separate module to allow us using it from tsan_analyze as well (we need it finally).

The diff is almost equal to http://codereview.chromium.org/175026,
I've only swapped two lines to make it applicable to the current trunk version.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26911

[Timur Iskhodzhanov, 2009-09-18 13:56:21]

Hi Dan,

Can you please review this changelist?

Thank you,
Timur Iskhodzhanov

[dank, 2009-09-18 16:06:02]

LGTM but fix the copyright date on the new file, should be 2009.

[not_the_right_glider, 2009-09-23 10:22:46]

On 2009/09/18 16:06:02, dank wrote:
> LGTM but fix the copyright date on the new file, should be 2009.

FYI: gdb cannot find the debug info for the Release configuration (i.e. Memcheck
on Mac), but I've double-checked it works for the Debug configuration.

[dank, 2009-09-23 10:31:12]

On 2009/09/23 10:22:46, ramosian.glider wrote:
> FYI: gdb cannot find the debug info for the Release configuration (i.e.
Memcheck
> on Mac), but I've double-checked it works for the Debug configuration.

Right, we have to run any bot that relies on this in Debug mode
(with -O1 for speed).

[not_the_right_glider, 2009-09-23 10:34:26]

On 2009/09/23 10:31:12, dank wrote:
> On 2009/09/23 10:22:46, ramosian.glider wrote:
> > FYI: gdb cannot find the debug info for the Release configuration (i.e.
> Memcheck
> > on Mac), but I've double-checked it works for the Debug configuration.
> 
> Right, we have to run any bot that relies on this in Debug mode
> (with -O1 for speed).

Well, then we don't have the line numbers for the Memcheck bot on Mac OS,
because it's in the Release mode. Is that intentional?
Can we proceed with this CL?

[dank, 2009-09-23 10:38:36]

On 2009/09/23 10:34:26, ramosian.glider wrote:
> Well, then we don't have the line numbers for the Memcheck bot on Mac OS,
> because it's in the Release mode. Is that intentional?

Nope.  I think that one needs to be switched to Debug, too,
not sure how it escaped.