Issue 211013: Introduce WebKit::WebSecurityOrigin as a wrapper around...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 211013: Introduce WebKit::WebSecurityOrigin as a wrapper around... (Closed)

Created:
11 years, 3 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
jorlow

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Introduce WebKit::WebSecurityOrigin as a wrapper around WebCore::SecurityOrigin. This provides us a little wiggle room in the future in case we ever want to provide more details about a security origin beyond just its stringified value. This was done on recommendation from Adam Barth. R=jorlow BUG=21967 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26554

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -54 lines)			Patch
M	chrome/renderer/render_view.h	View	2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View	2	3 chunks	+4 lines, -3 lines	0 comments	Download
M	webkit/api/public/WebFrame.h	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/api/public/WebFrameClient.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	webkit/api/public/WebSecurityOrigin.h	View		1 chunk	+17 lines, -19 lines	0 comments	Download
A +	webkit/api/src/WebSecurityOrigin.cpp	View		1 chunk	+19 lines, -16 lines	0 comments	Download
M	webkit/glue/empty_webframeclient.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/glue_util.h	View	1 2	3 chunks	+6 lines, -0 lines	0 comments	Download
M	webkit/glue/glue_util.cc	View	1 2	3 chunks	+9 lines, -0 lines	0 comments	Download
M	webkit/glue/webframe_impl.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webframe_impl.cc	View	1 2	3 chunks	+8 lines, -7 lines	0 comments	Download
M	webkit/glue/webframeloaderclient_impl.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/webkit.gyp	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages