Issue 211008: Fix plugin crash caused by removal of EMBED element during NPP_New....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 211008: Fix plugin crash caused by removal of EMBED element during NPP_New.... (Closed)

Created:
11 years, 3 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix plugin crash caused by removal of EMBED element during NPP_New. We get into trouble if FrameLoaderClient::createPlugin returns non- null if the EMBED element was removed from the DOM during NPP_New. This CL makes changes to main.cpp to support the layout test, which corresponds to http://trac.webkit.org/changeset/48361. R=jam BUG=21841 TEST=covered by layout test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26546

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -2 lines)			Patch
M	webkit/glue/webframeloaderclient_impl.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/tools/npapi_layout_test_plugin/main.cpp	View	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages