Issue 2110021: Use FilePath::DirName instead of the deprecated file_util::GetDirectoryFromPath.

Issue 2110021: Use FilePath::DirName instead of the deprecated file_util::GetDirectoryFromPath. (Closed)

Created:
10 years, 7 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Martin

CC:
chromium-reviews

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

Use FilePath::DirName instead of the deprecated file_util::GetDirectoryFromPath. BUG=24672 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48014

Patch Set 2 : fix win #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -23 lines)			Patch
M	chrome/browser/user_data_manager.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/web_applications/web_app.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/installer/setup/uninstall.cc	View	1	4 chunks	+11 lines, -10 lines	1 comment	Download
M	webkit/default_plugin/plugin_impl_win.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tfarina

On 2010/05/24 01:45:02, tony wrote: > Please fix the win try bot compilation failures. Fixed ...

10 years, 7 months ago (2010-05-24 02:59:13 UTC) #3

tony

LGTM http://codereview.chromium.org/2110021/diff/6001/3007 File chrome/installer/setup/uninstall.cc (right): http://codereview.chromium.org/2110021/diff/6001/3007#newcode153 chrome/installer/setup/uninstall.cc:153: file_util::IsDirectoryEmpty(parent_dir.value())) { Nit: It would be good to ...

10 years, 7 months ago (2010-05-24 03:32:29 UTC) #4

tfarina

10 years, 7 months ago (2010-05-24 03:47:14 UTC) #5

On 2010/05/24 03:32:29, tony wrote:
> LGTM
>

Committing now.

> http://codereview.chromium.org/2110021/diff/6001/3007
> File chrome/installer/setup/uninstall.cc (right):
> 
> http://codereview.chromium.org/2110021/diff/6001/3007#newcode153
> chrome/installer/setup/uninstall.cc:153:
> file_util::IsDirectoryEmpty(parent_dir.value())) {
> Nit: It would be good to make a FilePath version of this.  Would be good for a
> follow up patch.

Cool, will do it next.

Expand Messages | Collapse Messages