Issue 2110005: Also stop powerd in power_Backlight and power_LoadTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2110005: Also stop powerd in power_Backlight and power_LoadTest (Closed)

Created:
10 years, 7 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
Sameer Nanda

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Base URL:
ssh://git@chromiumos-git/autotest.git

Visibility:
Public.

Description

Also stop powerd in power_Backlight and power_LoadTest powerd isn't currently completely functional, but it can still interfere with power tests because it dims the screen during inactivity. BUG=none TEST=Ran on my eeepc

Patch Set 1 #

Total comments: 2

Patch Set 2 : Typo in comment #

Patch Set 3 : Address review comments #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	client/site_tests/power_Backlight/power_Backlight.py	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download
	M	client/site_tests/power_LoadTest/power_LoadTest.py	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sameer Nanda

LGTM w/ comment http://codereview.chromium.org/2110005/diff/1/3 File client/site_tests/power_LoadTest/power_LoadTest.py (right): http://codereview.chromium.org/2110005/diff/1/3#newcode205 client/site_tests/power_LoadTest/power_LoadTest.py:205: os.system('start powerd') switch the order of ...

10 years, 7 months ago (2010-05-17 18:32:25 UTC) #2

davidjames

10 years, 7 months ago (2010-05-17 18:45:35 UTC) #3

Committed. Thanks!

http://codereview.chromium.org/2110005/diff/1/3
File client/site_tests/power_LoadTest/power_LoadTest.py (right):

http://codereview.chromium.org/2110005/diff/1/3#newcode205
client/site_tests/power_LoadTest/power_LoadTest.py:205: os.system('start
powerd')
On 2010/05/17 18:32:25, sameer wrote:
> switch the order of these two -- you typically want to undo things in reverse
> order of doing them (although, it currently doesn't matter based on existing
> functionality of powerd).

Done.

Expand Messages | Collapse Messages