Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 21094: Adds a command line switch to allow the user to specify the location... (Closed)

Created:
11 years, 10 months ago by bekkra
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Adds a command line switch to allow the user to specify the location of the disk cache, rather than in the profile directory. The command line switch overrides the cache location regardless the chosen profile. The changed code ignores the value of the command line switch if it is not usable for this purpose. In this implementation, the supplied directory name must should not contain spaces. BUG=6688

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profile.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bekkra
I have uploaded a new change set, hopefully a little closer to acceptance. Please give ...
11 years, 10 months ago (2009-02-05 20:40:49 UTC) #1
rvargas (doing something else)
Please take a look at http://dev.chromium.org/developers/contributing-code In particular, the part about the user agreement and ...
11 years, 10 months ago (2009-02-06 00:07:17 UTC) #2
bekkra
11 years, 10 months ago (2009-02-06 23:11:59 UTC) #3
Updated.
I was expecting one in the committing team to add a new name when necessary,
since I can hardly see this minute change as a "contribution" to the project :)
Anyway, I've added my name (I signed the user agreement before starting the work
since I expect to leave a wee bit bigger footprint in the code than just this
change ;)).

//

Powered by Google App Engine
This is Rietveld 408576698