Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 21086: Include icudt38l_dat.s in icu (Closed)

Created:
11 years, 10 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
bradn
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Include icudt38l_dat.s in icu just like we do with icudt38.dll, so we don't have to worry about the messy generator step in the gyp-based build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/icu38/README.google View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
icudt38l_dat.s is part of this change, I don't know why Rietveld won't show it.
11 years, 10 months ago (2009-02-05 18:56:24 UTC) #1
bradn
11 years, 10 months ago (2009-02-05 20:35:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698