Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2108024: Provide access to the debuggee context from debug event listener (Closed)

Created:
10 years, 7 months ago by yurys
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Provide debug event listener with access to the debuggee context. Also introduce new event listener setter that allows to set a callback that accepts single parameter encapsulating all debug event details so that additional information can later be passed to the listener without breaking compatibility with existing clients. Committed: http://code.google.com/p/v8/source/detail?r=4693

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -16 lines) Patch
M include/v8-debug.h View 3 chunks +44 lines, -0 lines 2 comments Download
M src/api.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M src/debug.h View 1 chunk +21 lines, -0 lines 0 comments Download
M src/debug.cc View 4 chunks +59 lines, -14 lines 2 comments Download
M test/cctest/test-debug.cc View 1 chunk +23 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
10 years, 7 months ago (2010-05-20 14:30:33 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/2108024/diff/1/2 File include/v8-debug.h (right): http://codereview.chromium.org/2108024/diff/1/2#newcode198 include/v8-debug.h:198: * A EventCallback2 does not take posession of ...
10 years, 7 months ago (2010-05-20 14:42:23 UTC) #2
yurys
10 years, 7 months ago (2010-05-20 17:06:34 UTC) #3
http://codereview.chromium.org/2108024/diff/1/2
File include/v8-debug.h (right):

http://codereview.chromium.org/2108024/diff/1/2#newcode198
include/v8-debug.h:198: * A EventCallback2 does not take posession of the event
data,
On 2010/05/20 14:42:23, Søren Gjesse wrote:
> posession -> possession

Done.

http://codereview.chromium.org/2108024/diff/1/4
File src/debug.cc (right):

http://codereview.chromium.org/2108024/diff/1/4#newcode2128
src/debug.cc:2128: printf("xxx %d\n", event_listener_data_->IsUndefined());
On 2010/05/20 14:42:23, Søren Gjesse wrote:
> Please remove printf.

Oops, done.

Powered by Google App Engine
This is Rietveld 408576698