Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: net/socket/tcp_client_socket_win.cc

Issue 2108022: Make TCPClientSocket* inherit from NonThreadSafe. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/tcp_client_socket_win.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/tcp_client_socket_win.cc
diff --git a/net/socket/tcp_client_socket_win.cc b/net/socket/tcp_client_socket_win.cc
index fffc37a410dce31c60a32801e2077d27cfd11456..a24a313564cbd933ac95139870b51e982aed3e5a 100644
--- a/net/socket/tcp_client_socket_win.cc
+++ b/net/socket/tcp_client_socket_win.cc
@@ -292,6 +292,8 @@ TCPClientSocketWin::~TCPClientSocketWin() {
}
int TCPClientSocketWin::Connect(CompletionCallback* callback) {
+ DCHECK(CalledOnValidThread());
+
// If already connected, then just return OK.
if (socket_ != INVALID_SOCKET)
return OK;
@@ -368,6 +370,8 @@ int TCPClientSocketWin::DoConnect() {
}
void TCPClientSocketWin::Disconnect() {
+ DCHECK(CalledOnValidThread());
+
if (socket_ == INVALID_SOCKET)
return;
@@ -406,6 +410,8 @@ void TCPClientSocketWin::Disconnect() {
}
bool TCPClientSocketWin::IsConnected() const {
+ DCHECK(CalledOnValidThread());
+
if (socket_ == INVALID_SOCKET || waiting_connect_)
return false;
@@ -421,6 +427,8 @@ bool TCPClientSocketWin::IsConnected() const {
}
bool TCPClientSocketWin::IsConnectedAndIdle() const {
+ DCHECK(CalledOnValidThread());
+
if (socket_ == INVALID_SOCKET || waiting_connect_)
return false;
@@ -437,6 +445,7 @@ bool TCPClientSocketWin::IsConnectedAndIdle() const {
}
int TCPClientSocketWin::GetPeerAddress(AddressList* address) const {
+ DCHECK(CalledOnValidThread());
DCHECK(address);
if (!current_ai_)
return ERR_FAILED;
@@ -447,6 +456,7 @@ int TCPClientSocketWin::GetPeerAddress(AddressList* address) const {
int TCPClientSocketWin::Read(IOBuffer* buf,
int buf_len,
CompletionCallback* callback) {
+ DCHECK(CalledOnValidThread());
DCHECK_NE(socket_, INVALID_SOCKET);
DCHECK(!waiting_read_);
DCHECK(!read_callback_);
@@ -496,6 +506,7 @@ int TCPClientSocketWin::Read(IOBuffer* buf,
int TCPClientSocketWin::Write(IOBuffer* buf,
int buf_len,
CompletionCallback* callback) {
+ DCHECK(CalledOnValidThread());
DCHECK_NE(socket_, INVALID_SOCKET);
DCHECK(!waiting_write_);
DCHECK(!write_callback_);
@@ -546,6 +557,7 @@ int TCPClientSocketWin::Write(IOBuffer* buf,
}
bool TCPClientSocketWin::SetReceiveBufferSize(int32 size) {
+ DCHECK(CalledOnValidThread());
int rv = setsockopt(socket_, SOL_SOCKET, SO_RCVBUF,
reinterpret_cast<const char*>(&size), sizeof(size));
DCHECK(!rv) << "Could not set socket receive buffer size: " << GetLastError();
@@ -553,6 +565,7 @@ bool TCPClientSocketWin::SetReceiveBufferSize(int32 size) {
}
bool TCPClientSocketWin::SetSendBufferSize(int32 size) {
+ DCHECK(CalledOnValidThread());
int rv = setsockopt(socket_, SOL_SOCKET, SO_SNDBUF,
reinterpret_cast<const char*>(&size), sizeof(size));
DCHECK(!rv) << "Could not set socket send buffer size: " << GetLastError();
« no previous file with comments | « net/socket/tcp_client_socket_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698