Issue 2108022: Make TCPClientSocket* inherit from NonThreadSafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2108022: Make TCPClientSocket* inherit from NonThreadSafe. (Closed)

Created:
10 years, 7 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Make TCPClientSocket* inherit from NonThreadSafe. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47735

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -2 lines)			Patch
M	net/socket/tcp_client_socket_libevent.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	net/socket/tcp_client_socket_libevent.cc	View	9 chunks	+13 lines, -0 lines	0 comments	Download
M	net/socket/tcp_client_socket_win.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	net/socket/tcp_client_socket_win.cc	View	9 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

Dunno why the windows try bots aren't showing up. Here are their runs: http://build.chromium.org/buildbot/try-server/builders/win/builds/32366 http://build.chromium.org/buildbot/try-server/builders/win/builds/32370

10 years, 7 months ago (2010-05-19 21:06:16 UTC) #1

LGTM

Expand Messages | Collapse Messages