Issue 2108016: Move dynamic_annotations into a separate gyp file to break

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2108016: Move dynamic_annotations into a separate gyp file to break (Closed)

Created:
10 years, 7 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, Mark Mentovai

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Move dynamic_annotations into a separate gyp file to break a circular gyp dependency between allocator.gyp and base.gyp. BUG=44538 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47637

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -36 lines)			Patch
M	base/allocator/allocator.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/base.gypi	View	3 chunks	+2 lines, -35 lines	0 comments	Download
A	base/third_party/dynamic_annotations/dynamic_annotations.gyp	View	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

Can you please make sure it compiles on windows and linux_tsan trybots? Probably you may ...

10 years, 7 months ago (2010-05-19 07:50:49 UTC) #2

tony

On 2010/05/19 07:50:49, Timur Iskhodzhanov wrote: > Can you please make sure it compiles on ...

10 years, 7 months ago (2010-05-19 08:32:54 UTC) #3

Mark Mentovai

10 years, 7 months ago (2010-05-19 13:55:56 UTC) #4

Thank you!

On Wed, May 19, 2010 at 3:45 AM,  <tony@chromium.org> wrote:
> Reviewers: Timur Iskhodzhanov,
>
> Description:
> Move dynamic_annotations into a separate gyp file to break
> a circular gyp dependency between allocator.gyp and base.gyp.
>
> BUG=44538
>
> Please review this at http://codereview.chromium.org/2108016/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M base/allocator/allocator.gyp
>  M base/base.gypi
>  A base/third_party/dynamic_annotations/dynamic_annotations.gyp
>
>
>

Expand Messages | Collapse Messages