Issue 21080: Added the 'references' command to the debugger protocol to provide access to ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21080: Added the 'references' command to the debugger protocol to provide access to ... (Closed)

Created:
11 years, 10 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Added the 'references' command to the debugger protocol to provide access to the mirror features of retreiving all the objects referencing a given object and all objects instantiated by a given function. Added commands 'references' and 'instances' to the developer shell for using this new debugger protocol command. Committed: http://code.google.com/p/v8/source/detail?r=1234

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+262 lines, -34 lines)			Patch
M	src/d8.js	View		8 chunks	+100 lines, -28 lines	0 comments	Download
M	src/debug-delay.js	View		2 chunks	+37 lines, -0 lines	0 comments	Download
M	src/mirror-delay.js	View		1 chunk	+7 lines, -6 lines	0 comments	Download
A	test/mjsunit/debug-references.js	View	1	1 chunk	+118 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/21080/diff/1/2 File test/mjsunit/debug-references.js (right): http://codereview.chromium.org/21080/diff/1/2#newcode87 Line 87: '"arguments":{"expression":"Point"}}'; indentation one off?

11 years, 10 months ago (2009-02-05 13:51:32 UTC) #2

Søren Thygesen Gjesse

11 years, 10 months ago (2009-02-05 14:19:01 UTC) #3

http://codereview.chromium.org/21080/diff/1/2
File test/mjsunit/debug-references.js (right):

http://codereview.chromium.org/21080/diff/1/2#newcode87
Line 87: '"arguments":{"expression":"Point"}}';
On 2009/02/05 13:51:32, Mads Ager wrote:
> indentation one off?

Done.

Expand Messages | Collapse Messages