Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 21076: Fixed the debugger compile events.... (Closed)

Created:
11 years, 10 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fixed the debugger compile events. The debugger compile events (BeforeCompile and AfterCompile) have not been used by any V8 debuggers lately and where actually not working any more. Added the correct information to the compile event. Added a simple 'trace compile' command to the developer shell for testing. Added a test for compile evnets. Committed: http://code.google.com/p/v8/source/detail?r=1230

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -85 lines) Patch
M src/d8.js View 1 5 chunks +99 lines, -61 lines 0 comments Download
M src/d8-debug.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/debug.h View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 4 chunks +13 lines, -11 lines 0 comments Download
M src/debug-delay.js View 1 chunk +19 lines, -10 lines 0 comments Download
A test/mjsunit/debug-compile-event.js View 1 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-05 09:40:58 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/21076/diff/1/5 File src/d8.js (right): http://codereview.chromium.org/21076/diff/1/5#newcode106 Line 106: if (event.eventType() == Debug.DebugEvent.Break) { How about ...
11 years, 10 months ago (2009-02-05 09:56:40 UTC) #2
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-05 10:09:15 UTC) #3
http://codereview.chromium.org/21076/diff/1/5
File src/d8.js (right):

http://codereview.chromium.org/21076/diff/1/5#newcode106
Line 106: if (event.eventType() == Debug.DebugEvent.Break) {
On 2009/02/05 09:56:40, Mads Ager wrote:
> How about a switch on the event type instead?

Done.

http://codereview.chromium.org/21076/diff/1/2
File test/mjsunit/debug-compile-event.js (right):

http://codereview.chromium.org/21076/diff/1/2#newcode1
Line 1: // Copyright 2008 the V8 project authors. All rights reserved.
On 2009/02/05 09:56:40, Mads Ager wrote:
> 2009

Done.

http://codereview.chromium.org/21076/diff/1/2#newcode35
Line 35: 
On 2009/02/05 09:56:40, Mads Ager wrote:
> Why put spaces here and not before the function?

Tried to indicate that these variables where set by the function. Did not work.
Changed formatting and added comments.

Powered by Google App Engine
This is Rietveld 408576698