build/gyp_chromium - Issue 2107018: Fix ChromiumOS build (it still has circular dependencies).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gyp_chromium

Issue 2107018: Fix ChromiumOS build (it still has circular dependencies). (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/gyp_chromium

diff --git a/build/gyp_chromium b/build/gyp_chromium

index ab05ae9a85c2ddfcac0987b0dfaa25e919b0b6e4..998d131e1b4521caaed242f7fe64c4918506c718 100755

--- a/build/gyp_chromium

+++ b/build/gyp_chromium

@@ -79,7 +79,9 @@ if __name__ == '__main__':

# violation of the rule causes Xcode to misbehave badly.

# TODO(mark): Find and kill remaining circular dependencies, and remove this

# option. http://crbug.com/35878.

- if sys.platform not in ('darwin', 'linux2'):

+ # TODO(tc): Fix circular dependencies in ChromiumOS then add linux2 to the

+ # list.

+ if sys.platform not in ('darwin',):

args.append('--no-circular-check')

# If CHROMIUM_GYP_SYNTAX_CHECK is set to 1, it will invoke gyp with --check

« no previous file with comments | « no previous file | no next file » | no next file with comments »