Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2106015: Move data types used in the importer process to common/, in preparation for i... (Closed)

Created:
10 years, 7 months ago by Miranda Callahan
Modified:
9 years, 7 months ago
Reviewers:
brettw, jeremy
CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Move data types used in the importer process to common/, in preparation for import to run out of process. BUG=18774 TEST= none. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47675

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -259 lines) Patch
M chrome/browser/cocoa/import_progress_dialog.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/import_settings_dialog.mm View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run_mac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_bar_gtk.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/first_run_dialog.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/import_dialog_gtk.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/import_progress_dialog_gtk.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/content_page_gtk.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_types.h View 1 2 3 4 chunks +2 lines, -150 lines 0 comments Download
M chrome/browser/history/history_types.cc View 1 2 3 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/importer/firefox2_importer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox3_importer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/ie_importer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/importer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/importer_bridge.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/importer/importer_data_types.h View 1 2 3 1 chunk +0 lines, -58 lines 0 comments Download
M chrome/browser/importer/importer_list.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/importer/importer_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/safari_importer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/toolbar_importer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/importer_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/importing_progress_view.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/content_page_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
A + chrome/common/importer_data_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
A chrome/common/url_row_type.h View 1 1 chunk +174 lines, -0 lines 0 comments Download
A chrome/common/url_row_type.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Miranda Callahan
This CL starts moving importer classes into common, where they need to be for out-of-process ...
10 years, 7 months ago (2010-05-18 23:29:45 UTC) #1
Miranda Callahan
10 years, 7 months ago (2010-05-19 01:15:08 UTC) #2
Miranda Callahan
10 years, 7 months ago (2010-05-19 15:54:11 UTC) #3
brettw
LGTM http://codereview.chromium.org/2106015/diff/5001/6031 File chrome/common/url_row_type.h (right): http://codereview.chromium.org/2106015/diff/5001/6031#newcode15 chrome/common/url_row_type.h:15: namespace history { Can you add a comment ...
10 years, 7 months ago (2010-05-19 16:02:07 UTC) #4
Miranda Callahan
10 years, 7 months ago (2010-05-19 16:20:23 UTC) #5
Thanks, Brett.

http://codereview.chromium.org/2106015/diff/5001/6031
File chrome/common/url_row_type.h (right):

http://codereview.chromium.org/2106015/diff/5001/6031#newcode15
chrome/common/url_row_type.h:15: namespace history {
On 2010/05/19 16:02:07, brettw wrote:
> Can you add a comment at the top of the file about why this is in common
rather
> than browser/history with everything else?

Done.

Powered by Google App Engine
This is Rietveld 408576698