Issue 2106009: Always build pristine image as well as dev/test image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2106009: Always build pristine image as well as dev/test image. (Closed)

Created:
10 years, 7 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git//chromeos

Visibility:
Public.

Description

Always build pristine image as well as dev/test image. TEST=Tested build process. Tested dev image, test image and base image by booting all three and logging in.

Patch Set 1 #

Patch Set 2 : Remove whitespaces #

Total comments: 2

Patch Set 3 : Fix ws #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -44 lines)			Patch
	M	src/scripts/build_image	View	1 2	5 chunks	+81 lines, -30 lines	0 comments	Download
	M	src/scripts/mount_gpt_image.sh	View	1	2 chunks	+10 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

Add pristine image called chromiumos_base.image to developer builds (non-developer builds are unchanged).

10 years, 7 months ago (2010-05-18 01:46:51 UTC) #1

petkov

10 years, 7 months ago (2010-05-18 05:16:04 UTC) #2

LGTM

http://codereview.chromium.org/2106009/diff/2001/3001
File src/scripts/build_image (right):

http://codereview.chromium.org/2106009/diff/2001/3001#newcode76
src/scripts/build_image:76: PRISTINE_IMAGE_NAME=chromiumos_base_image.bin
Does it make sense to keep the base name the same across all images, and just
add a suffix? I.e., chromiumos_image.bin, chromiumos_image_base.bin,
chromium_image_test.bin, etc.

http://codereview.chromium.org/2106009/diff/2001/3001#newcode223
src/scripts/build_image:223: if [[ -x "${ROOT_FS_DIR}/usr/local/bin/vim" ]] ;
then
no space before ;

Expand Messages | Collapse Messages